[CRIU] Re: [PATCH 3/8] dump: socket queues support

[Pavel Emelyanov]

> @@ -1279,7 +1289,14 @@ int cr_dump_tasks(pid_t pid, struct cr_options *opts)
>  			goto err;
>  
>  		if (item->pid == pid) {
> -			if (!cr_dump_fdset_open(item->pid, CR_FD_DESC_USE(CR_FD_PSTREE), cr_fdset))
> +			/*
> +			 * Prepare for socket queues in advance. They are not per-task, but
> +			 * per-someother-task which makes restore tricky. Thus save them in
> +			 * "global" image.
> +			 */
> +
> +			if (!cr_dump_fdset_open(item->pid, CR_FD_DESC_USE(CR_FD_PSTREE) |
> +						CR_FD_DESC_USE(CR_FD_SK_QUEUES), cr_fdset))
>  				goto err;

This fdset will be closed after the first task dump. How do you plan to dump the other
tasks' queues? (BTW, this shows your test is bad as well)

>  			if (dump_pstree(pid, &pstree_list, cr_fdset))
>  				goto err;