[CRIU] Re: [PATCH] show: Set log-level to LOG_WARN

Pavel Emelyanov xemul at parallels.com
Mon Feb 27 07:31:01 EST 2012


On 02/27/2012 04:22 PM, Kir Kolyshkin wrote:
> 
> On Feb 27, 2012 11:36 AM, "Pavel Emelyanov" <xemul at parallels.com<mailto:xemul at parallels.com>> wrote:
>>
>> On 02/25/2012 06:23 PM, Cyrill Gorcunov wrote:
>>> We use pr_info for "show" action so
>>> adjust log-level accordingly.
>>
>> Show should dump info to STDOUT (not STDERR, as it is now :\ ) regardless
>> of the loglevel.
> 
> Guys,
> 
> The source of the problem here is you mix logging with plain and simple output.
> 
> Logging is for keeping track of what and then a program had done. Output is what you specifically request to be printed. You can configure a program to log to a file (or maybe syslog), but its output always go to stdout.
> 
> Therefore, no logging functions should be used for output such as one of 'show' command.

Where above did I say that show had to use the logging engine?
But anyway -- thanks, Kir, for explaining this in simple words.



More information about the CRIU mailing list