[CRIU] Re: [PATCH 2/3] show: Always print informative messages

[Pavel Emelyanov]

On 02/27/2012 02:20 PM, Cyrill Gorcunov wrote:
> On Mon, Feb 27, 2012 at 02:11:24PM +0400, Pavel Emelyanov wrote:
>> O_o
>>
>> Как-то жутко у нас это все выглядит. Хотя, конечно, лучше, чем было.
>> Давай step 2/N.
>>
>>> #define printk(fmt, ...)     printk_level(LOG_WARN,
>>
>> Rename to smth without k
>> Should emit message regardless of the loglevel set
>>
> 
> printk is just a habbit. Maybe plain print(), or pr_always?

print_msg() is ok

>>> #define pr_info(fmt, ...)    printk_level(LOG_WARN,
>>
>> Should emit message with LOG_DEBUG level
> 
> Dunno. Actually I would prefer to have 4 log levels
> 
> LOG_WARN -- not error and we can continue, but user _must_ point attention on it
> LOG_INFO -- simply informative message, this usually not printed until requested
>             from command line
> LOG_DEBUG -- debug messages, never printed until requested from command line
> LOG_ERR -- that's error, we can't continue

OK, but there should be 1:1 mapping betweek LOG_ levels and pr_ helpers.