[CRIU] Re: [PATCH 2/3] show: Always print informative messages

Pavel Emelyanov xemul at parallels.com
Mon Feb 27 05:11:24 EST 2012


O_o

Как-то жутко у нас это все выглядит. Хотя, конечно, лучше, чем было.
Давай step 2/N.

> #define printk(fmt, ...)     printk_level(LOG_WARN,

Rename to smth without k
Should emit message regardless of the loglevel set

> #define pr_info(fmt, ...)    printk_level(LOG_WARN,

Should emit message with LOG_DEBUG level

> #define pr_err(fmt, ...)     printk_level(LOG_ERROR,

OK

> #define pr_panic(fmt, ...)   printk_level(LOG_ERROR,

Remove, replace all callers with pr_err

> #define pr_warning(fmt, ...) printk_level(LOG_WARN,

OK

> #define pr_debug(fmt, ...)   printk_level(LOG_DEBUG,

Remove, replace all callers with pr_info

> #define pr_perror(fmt, ...)  pr_err(fmt ": %m\n", ##__VA_ARGS__)

OK

cr-show.c should use (renamed) printk-s everywhere.



More information about the CRIU mailing list