[CRIU] Re: [RFC] files: Add union { addr; fd } for file entries
Cyrill Gorcunov
gorcunov at openvz.org
Wed Feb 22 10:53:08 EST 2012
On Wed, Feb 22, 2012 at 07:49:01PM +0400, Pavel Emelyanov wrote:
> > + union {
> > + u64 addr;
> > + u64 fd;
> > + };
>
> NAK. Entries should be plain.
>
Why? This is only to make an alias to the
name of the variable.
Frankly, having code like
tmp = recv_fd(fe->addr);
if (tmp < 0) {
pr_err("Can't get fd %d\n", tmp);
return -1;
}
close(fe->addr);
a bit strange, why close(addr) I always asking myself???
IF there strong NAK, maybe we could use some
macro alias then?
Cyrill
More information about the CRIU
mailing list