[CRIU] [PATCH 2/6] Makefile: remove an unneeded dependency

Kinsbursky Stanislav skinsbursky at openvz.org
Wed Feb 22 10:00:37 EST 2012


22.02.2012 18:53, Kir Kolyshkin пишет:
> On 02/22/2012 01:24 PM, Kinsbursky Stanislav wrote:
>> 22.02.2012 02:09, Kir Kolyshkin пишет:
>>> There is no need to make .d files for restorer-blob.h
>>>
>>> Signed-off-by: Kir Kolyshkin<kir at openvz.org>
>>> ---
>>>     Makefile |    2 +-
>>>     1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index d5ffeca..3486a73 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -103,7 +103,7 @@ $(RHEAD-BIN): $(ROBJS) $(RHEAD-LDS)
>>>     	$(E) "  GEN     " $@
>>>     	$(Q) $(LD) -T $(patsubst %.bin,%.lds.S,$@) -o $@ $(ROBJS)
>>>
>>> -$(RHEAD-BLOB-GEN): $(RHEAD-BIN) $(RDEPS-BLOB)
>>> +$(RHEAD-BLOB-GEN): $(RHEAD-BIN)
>>>     	$(E) "  GEN     " $@
>>>     	$(Q) $(SH) gen-offsets.sh			\
>>>     		restorer_h__				\
>> You forgot to remove RDEPS-BLOB itself.
> Thanks for catching this! The problem is I still haven't figured out
> which deps are needed for which targets.
>
> I hope I will be able to dig into that soon, and untangle the Makefile a
> bit more. For now, let it stay as it is.

None of them, Kir. Or all of them. :)
You can find a general rule for building dep targets in the Makefile. And also 
you can find, that all this dep files are included into the Makefile.
This actually means, that before parsing Makefile itself, make will build (if 
required) and include dep targets into it.
So there is nothing to fix here.
BTW, thanks for cleaning up things like RDEPS-BLOB (this garbage left from 
initial versions of Makefile).



-- 
Best regards,
Stanislav Kinsbursky




More information about the CRIU mailing list