[CRIU] Re: [PATCH 3/8] parasite: Use SET_PARASITE_STATUS_SUCCESS where appropriate

[Cyrill Gorcunov]

On Wed, Feb 22, 2012 at 02:41:22PM +0400, Pavel Emelyanov wrote:
> On 02/22/2012 12:22 AM, Cyrill Gorcunov wrote:
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> 
> NAK
> 
> The whole parasite_status_t is ugly. We have 4 return codes from parasite:
> the one returned by function, the abstract PARASITE_CMD_ERR_XXX one, the
> syscall retcode and the __LINE__. Plus, we have a mess in PARASITE_CMD_ERR_XXX
> macroses and the way they are set.
> 
> Please, rework it to look like:
> 
> * Only 3 return codes from parasite -- whether the operation succeeded or not,
>   the __LINE__ where error occurred and the corresponding errno value (if applicable).
> * Remove PARASITE_CMD_ERR_XXX set
> * The SET_PARASITE_STATUS_SUCCESS should thus disappear.

OK

	Cyrill