[CRIU] [PATCH 4/8] parasite: Add missing 'void' in function declarations

Cyrill Gorcunov gorcunov at openvz.org
Wed Feb 22 04:25:35 EST 2012


On Wed, Feb 22, 2012 at 01:20:55PM +0400, Stanislav Kinsbursky wrote:
> 
> I have some other cleanup solution. Consider it, please:
> 1) Pass args pointer to every to command handler function (even if
> it's not used inside). BTW, explicit type cast for void pointers is
> redundant.

There were a patch which makes so. This one is just to make it
step-by-step solution, so the code would work after every single
commit in the series.

> 2) Call SET_PARASITE_STATUS_SUCCESS(st) only (!) in
> parasite_service() in case of command success. Thus collect of
> command handler function result is required.

Yeah, on one hand this indeed would make it cleaner, on the
other hands this would be strange that callees might set
error codes to status but will not set up success status.
So, I dont know.

	Cyrill


More information about the CRIU mailing list