[CRIU] Re: [PATCH] parasite-syscall: some cleanup

[Kinsbursky Stanislav]

21.02.2012 19:45, Pavel Emelyanov пишет:
> On 02/21/2012 07:38 PM, Kinsbursky Stanislav wrote:
>> 21.02.2012 19:25, Cyrill Gorcunov пишет:
>>> On Tue, Feb 21, 2012 at 05:47:53PM +0300, Kinsbursky Stanislav wrote:
>>>> Removed redundant on-stack variables typeof parasite_status_t and memcpy
>>>> between them and parasite_ctl->addr_args object. Ando a lot of cleanup done
>>>> around.
>>>>
>>>> Signed-off-by: Stanislav Kinsbursky<skinsbursky at openvz.org>
>>>> ---
>>> Hi Stas, the patch is more-less fine for me. The main reason
>>> we were poking arguments left and right is that initially
>>> we have had no local mapping of parasite memory.
>>>
>>> Still this patch confuses me, but a little bit. Now parasite_execute
>>> looks like
>>>
>>> parasite_execute(unsigned long cmd, struct parasite_ctl *ctl)
>>>
>>> ie it's driven by cmd, BUT arguments for command are prepared
>>> by a caller code somewhere else.
>> Preparing arguments before execution call looks straight-forward to me.
>> You, confused, because cmd will be copied to ctl internals inside
>> parasite_execute(), don't you?
>> Yes, it will. But if we will left only data argument, then these calls will not
>> look as clear current solution.
>> But, anyway, I don't really insist here.
>> Let's wait for third opinion, what do you think?
>>
> Ну да, выглядит как-то мутновато. Придумай что-нибудь более веселое :)

Ну вы, блин, даёте, ребята.
Сами нафигачили чёрте-чего, не прибрали, я теперь вам, видишь ли, "мутновато".
Если убрать команду-аргумент - не думаю, что будет сильно выглядеть веселее.
Но как хочите.


-- 
Best regards,
Stanislav Kinsbursky