[CRIU] Re: [PATCH] parasite-syscall: some cleanup

[Cyrill Gorcunov]

On Tue, Feb 21, 2012 at 05:47:53PM +0300, Kinsbursky Stanislav wrote:
> Removed redundant on-stack variables typeof parasite_status_t and memcpy
> between them and parasite_ctl->addr_args object. Ando a lot of cleanup done
> around.
> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky at openvz.org>
> ---

Hi Stas, the patch is more-less fine for me. The main reason
we were poking arguments left and right is that initially
we have had no local mapping of parasite memory.

Still this patch confuses me, but a little bit. Now parasite_execute
looks like

parasite_execute(unsigned long cmd, struct parasite_ctl *ctl)

ie it's driven by cmd, BUT arguments for command are prepared
by a caller code somewhere else. Which is confusing. Probably
it would worth to drop cmd completely and prepare it in
the caller code as well.

	Cyrill