[CRIU] Re: [PATCH] restorer: close log file before detaching from
crtools
Cyrill Gorcunov
gorcunov at openvz.org
Mon Feb 20 09:28:33 EST 2012
On Mon, Feb 20, 2012 at 05:12:13PM +0300, Kinsbursky Stanislav wrote:
...
> @@ -773,4 +773,13 @@ core_restore_end:
> write_num_n(sys_getpid());
> sys_exit(-1);
> return -1;
> +
> +core_restore_failed:
> + asm volatile(
> + "movq %0, %%rsp \n"
> + "jmp *%1 \n"
> + :
> + : "r"(ret), "r"(line)
> + : );
> + return ret;
> }
>
Stas, this snippet is crap! Never-ever jump to the addresses
other than being invalid for sure (such as nil and etc).
(Holy cow, thanks we're on ring 3 ;)
The race between restorer and zdtm suite looks for me like
a zdtm problem, not crtools. Guys, is there some way to
eliminate the race somehow differently?
Cyrill
More information about the CRIU
mailing list