[CRIU] Re: [PATCH 5/5] open_proc() and friends: hide pid_dir

Pavel Emelyanov xemul at parallels.com
Fri Feb 17 07:33:41 EST 2012


On 02/17/2012 01:39 AM, Kir Kolyshkin wrote:
> This patch tries to introduce lazy and hidden pid_dir support,
> meaning one don't have to worry about pid_dir but the optimization
> is still there.
> 
> The patch relies on the fact that we work with many /proc/pid files for
> one pid, then for another pid and so on, i.e. not in a random manner.
> 
> The idea is when we call open_proc() with a new pid for the first time,
> the appropriate /proc/PID directory is opened and its fd is stored.
> Next call to open_proc() with the same PID only need to check that
> the PID is not changed. In case PID is changed, we close the old one
> and open/store a new one.
> 
> Now the code using open_proc() and friends:
> - does not need to carry proc_pid around, pid is enough
> - does not need to call open_pid_proc()
> 
> The only thing that can't be done in that "lazy" mode is closing the last
> PID fd, thus close_pid_proc().
> 
> Signed-off-by: Kir Kolyshkin <kir at openvz.org>

Ack


More information about the CRIU mailing list