[CRIU] [PATCH cr 1/2] zdtm: don't kill test processes in case an error

[Kir Kolyshkin]

On 02/15/2012 01:15 AM, Andrey Vagin wrote:
> We want to have maximum info about an error.
>
> Signed-off-by: Andrey Vagin<avagin at openvz.org>
> ---
>   test/zdtm.sh |    9 +--------
>   1 files changed, 1 insertions(+), 8 deletions(-)
>
>
> diff --git a/test/zdtm.sh b/test/zdtm.sh
> index 3b90005..c2076cb 100644
> --- a/test/zdtm.sh
> +++ b/test/zdtm.sh
> @@ -65,14 +65,7 @@ run_test()
>
>   	echo Dump $pid
>   	mkdir -p $ddump
> -	setsid $CRTOOLS dump -D $ddump -o dump.log -t $pid $args
> -	ret=$?
> -	while :; do
> -		killall -9 $tname&>  /dev/null || break
> -		echo Waiting...
> -		sleep 1
> -	done
> -	[ "$ret" -eq 0 ] || return 1
> +	setsid $CRTOOLS dump -D $ddump -o dump.log -t $pid $args || return 1;

(1) No need for semicolon after return 1 statement

(2) We have discussed it today, and we have agreed that we want to print 
something like

     WARNING: process $tname is left running for your debugging needs

I don't see it here.

(3) You are not using 'ret' variable anymore, but you left 'local ret' 
there, should be removed.

>
>   	if expr "$args" : ' -s'; then
>   		killall -CONT $tname

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://openvz.org/pipermail/criu/attachments/20120215/e2275192/attachment.html