[CRIU] [crtools-bot for Kir Kolyshkin ] parasite.c: use .space not .skip for inline asm

Cyrill Gorcunov gorcunov at openvz.org
Tue Feb 14 02:27:06 EST 2012


The commit is pushed to "master" and will appear on git://github.com/cyrillos/crtools.git
------>
commit fcfd705d39b10da4a01227bc0cba75ab2dbab4b3
Author: Kir Kolyshkin <kir at openvz.org>
Date:   Tue Feb 14 03:00:24 2012 +0400

    parasite.c: use .space not .skip for inline asm
    
    In the beginning it was the Word, and the Word was .space.
    Later, .skip was introduced as a synonym for .space,
    initially only for 680x0 platform.
    
    But the sole reason for this patch is that I use clang/llvm
    to check the code and unfortunately it does not understand .skip,
    printing long ugly warnings I'd like to avoid.
    
    Signed-off-by: Kir Kolyshkin <kir at openvz.org>
    Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
---
 parasite.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/parasite.c b/parasite.c
index ff49605..55064c5 100644
--- a/parasite.c
+++ b/parasite.c
@@ -454,12 +454,12 @@ static void __parasite_head __used parasite_head(void)
 		     ".long 0									\n\t"
 		     "parasite_args:								\n\t"
 		     ".long 0									\n\t"
-		     ".skip "__stringify(PARASITE_ARG_SIZE)",0					\n\t"
-		     ".skip "__stringify(PARASITE_STACK_SIZE)", 0				\n\t"
+		     ".space "__stringify(PARASITE_ARG_SIZE)",0					\n\t"
+		     ".space "__stringify(PARASITE_STACK_SIZE)", 0				\n\t"
 		     "parasite_stack:								\n\t"
 		     ".long 0									\n\t"
 		     "parasite_brk:								\n\t"
-		     ".skip "__stringify(PARASITE_BRK_SIZE)", 0					\n\t"
+		     ".space "__stringify(PARASITE_BRK_SIZE)", 0				\n\t"
 		     ".long 0									\n\t");
 }
 


More information about the CRIU mailing list