[CRIU] Re: [PATCH v3 1/4] IPC: dump shared memory

Kinsbursky Stanislav skinsbursky at openvz.org
Thu Feb 9 03:43:38 EST 2012


09.02.2012 12:33, Pavel Emelyanov пишет:
>>>> +
>>>>    #define VMA_AREA_NONE		(0<<    0)
>>>>    #define VMA_AREA_REGULAR	(1<<    0)	/* Dumpable area */
>>>>    #define VMA_AREA_STACK		(1<<    1)
>>>> diff --git a/ipc_ns.c b/ipc_ns.c
>>>> +}
>>>> +
>>>> +static int dump_ipc_shm_seg(int fd, int id, const struct shmid_ds *ds)
>>> By now you should either place here check for the number of attaches should be zero
>>> or implement dumping/restoring the attaches to tasks.
>> What for?
> To make sure we do things properly. If we do know that we don't handle attached
> segments we should deny dumping them.

Ok, I'll add check for attach counter is zero for now.

-- 
Best regards,
Stanislav Kinsbursky




More information about the CRIU mailing list