[CRIU] Re: [PATCH] IPC: collect and dump tunables sequentially

[Kinsbursky Stanislav]

07.02.2012 20:26, Cyrill Gorcunov пишет:
> On Tue, Feb 07, 2012 at 06:45:32PM +0300, Kinsbursky Stanislav wrote:
>> This patch removes collect stage and dumps tunables object right after
>> collect.
>>
>> Signed-off-by: Stanislav Kinsbursky<skinsbursky at parallels.com>
>> ---
>> +	case IPCNS_TUN_MAGIC:
>> +		show_ipcns_tun(fd);
>>   		break;
>>
> ...
>> -	/* IPC namespace */
>> -	[CR_FD_IPCNS] = {
>> -		.fmt	= FMT_FNAME_IPCNS,
>> -		.magic	= IPCNS_MAGIC,
>> +	/* IPC namespace tunables */
>> +	[CR_FD_IPCNS_TUN] = {
>> +		.fmt	= FMT_FNAME_IPCNS_TUN,
>> +		.magic	= IPCNS_TUN_MAGIC,
>>   	},
>>   };
>>
> Btw, Stas, this TUN trigram has nothing to do with tun
> net device, right? So can we change it to something
> different from "tun"? I'm asking so since tun is pretty
> strong abbreviature and widely used in context of "tun/tap".
>
> 	Cyrill

This all (with Pavel comment) sounds strange to me. The name is "IPCNS_TUN".
Probably, tun/tap devices will abbreviates to something like "NETNS_DEV_TUN", etc.
How anyone can lost in this object types?

-- 
Best regards,
Stanislav Kinsbursky