[CRIU] Re: [PATCH cr 3/5] parasite: create unix socket in parasite for transfering fd (v2)

[Pavel Emelyanov]

On 02/01/2012 02:00 PM, Andrey Vagin wrote:
> 
> Before we used absolute pathes to images and wrote logging messages in
> stderr of a target process.
> 
> Now we are able to create fd and send it to parasite.
> 
> v2: change name of parasite's commands
> 
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  include/parasite.h |   11 ++++++
>  parasite-syscall.c |   97 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  parasite.c         |   45 +++++++++++++++++++++++-
>  3 files changed, 152 insertions(+), 1 deletions(-)
> 

> +static int parasite_open_socket(struct parasite_ctl *ctl, pid_t pid)
> +{
> +	struct parasite_socket_args args = { };
> +	int ret;
> +
> +	args.sun_len = get_socket_name(&args.saddr, pid);
> +
> +	ret = parasite_execute(PARASITE_CMD_INIT, ctl,
> +			(parasite_status_t *)&args, sizeof(args));
> +	return ret;
> +}

I'd understand if function called parasite_init() did PARASITE_CMD_SEND_SOCKET,
but not the vice versa.

Plz, find some better naming for that.