[CRIU] [PATCH 12/17] proc_parse: Add parsing of fanotify entries

[Pavel Emelyanov]

On 12/24/2012 06:15 PM, Cyrill Gorcunov wrote:
> On Mon, Dec 24, 2012 at 06:07:08PM +0400, Pavel Emelyanov wrote:
>>> +		if (fdinfo_field(str, "inotify wd")	||
>>> +		    fdinfo_field(str, "fanotify ino")	||
>>> +		    fdinfo_field(str, "fanotify mnt_id")) {
>>>  			FhEntry f_handle = FH_ENTRY__INIT;
>>> +			struct fsnotify_params *p = arg;
>>>  			int hoff;
>>>  
>>>  			fsnotify_wd_entry__init(&entry.fsy);
>>>  			entry.fsy.f_handle = &f_handle;
>>>  			entry.fsy.has_type = true;
>>>  
>>>  			if (type != FD_TYPES__FSNOTIFY)
>>
>> The "inotify wd" string results in parse error? Why?
> 
> What you mean by "why?" here? These three are the formats we do
> support now, type FD_TYPES__FSNOTIFY is the "common" type for
> any fsnotify object. Thus if caller meets any of them it's implied
> that we're rasing fsnotify object. That said -- we should never
> meet any of these fields if only we're not parsing the fdinfo
> from our fsnotify subsystem (or there some kernel error).

Ah, I see. FSnotify == FAnotify OR Inotify. OK.

>>
>> instead of plain and readable
> 
> Thanks, i'll think about it.

Thank you.

> 	Cyrill
> .
>