[CRIU] [PATCH 09/17] fsnotify: Update open_fsnotify_fd to choose helper depending on notif type

Cyrill Gorcunov gorcunov at openvz.org
Mon Dec 24 08:45:58 EST 2012


On Mon, Dec 24, 2012 at 05:22:35PM +0400, Pavel Emelyanov wrote:
> On 12/11/2012 01:34 AM, Cyrill Gorcunov wrote:
> > 
> > The open_fsnotify_fd now chooses which helper to use
> > for notification restore depending on notification
> > type. At moment inotifies are only supported so I
> > renamed open/restore_one helpers accodingly.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  fsnotify.c | 45 +++++++++++++++++++++++++++++++++------------
> >  1 file changed, 33 insertions(+), 12 deletions(-)
> > 
> 
> 
> > @@ -162,7 +162,7 @@ err:
> >  	return path;
> >  }
> >  
> > -static int restore_one_fsnotify(int inotify_fd, struct fsnotify_wd_info *info)
> > +static int restore_one_inotify(int inotify_fd, struct fsnotify_wd_info *info)
> >  {
> >  	FsnotifyWdEntry *iwe = info->iwe;
> >  	int ret = -1, wd, target = -1;
> 
> You have already renamed this fn in this set.

Yes, but it was done intentionally -- at first we rename helpers to fsnotify,
which is a general name for this subsystem, then we split general helpers to
two -- inotify and fanotify.

	Cyrill


More information about the CRIU mailing list