[CRIU] [PATCH 08/17] fsnotify: Add try_open_handle helper

Cyrill Gorcunov gorcunov at openvz.org
Mon Dec 24 08:43:33 EST 2012


On Mon, Dec 24, 2012 at 05:19:53PM +0400, Pavel Emelyanov wrote:
> On 12/11/2012 01:34 AM, Cyrill Gorcunov wrote:
> > 
> > The helper chooses which path to get, if remapped
> > name present (ghost file) we use it, otherwise we
> > try to open file handle.
> > 
> > The reason for separate helper is that both inotify
> > and fanotify will use it, so we should try to eliminate
> > code duplication.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> 
> This does more than just split one fn into two. Don't merge these
> two changes in one patch.

Hmm, not sure if I follow here. Could you please elaborate?
We've added try_open_handle helper here and used it in
restore_one_fsnotify, what's wrong?

	Cyrill


More information about the CRIU mailing list