[CRIU] [PATCH 03/17] fsnotify: Extend protobuf format to keep notification type and specific parameters
Cyrill Gorcunov
gorcunov at openvz.org
Mon Dec 24 08:39:51 EST 2012
On Mon, Dec 24, 2012 at 05:21:15PM +0400, Pavel Emelyanov wrote:
> >
> > +
> > + optional fsnotify_type type = 5;
> > + optional fanotify_glob faglob = 6;
>
> Do we _really_ need two fields for that? Why not
>
> if_fanotify(FsnotifyFileEntry *e)
> {
> return e->faglob != NULL;
> }
Well, strictly speaking, yes, but having @type and @faglob
make the image more readable from my pov.
Cyrill
More information about the CRIU
mailing list