[CRIU] [PATCH 01/20] x86: moved x86-specific files into the directory arch/x86.

[Pavel Emelyanov]

On 12/22/2012 08:08 PM, Alexander Kartashov wrote:
> On 12/19/2012 06:46 PM, Pavel Emelyanov wrote:
>> Why? I don't propose to create include/x.h for every header moved to arch/.
>> Just keep arch-specific headers in arch/<arch>//include/asm//, not arch/<arch>/.
> 
> I want to make the issue as clear as it's possible. Is it OK to move
> the headers listed in the patch comment, specifically
> 
> * include/atomic.h,
> * include/linkage.h,
> * include/memcpy_64.h,
> * include/types.h,
> * include/atomic.h,
> 
> into the directory arch/x86/include/, not into arch/x86/include/asm

No it's not OK. If I see #include <foo.h> in the .c file I want to make
sure the file in question is _not_ in the arch/ directory. Please, put
all this stuff in the arch/<arch>/include/asm/ directory. It's long, but
it's worth doing so.

> and add the option -Iarch/x86/include to the compiler in order
> to avoid changing directives that include the files mentioned above
> in all files of the project?
> 
> -- 
> Sincerely yours,
> Alexander Kartashov
> 
> Intern
> Core team
> 
> www.parallels.com <http://www.parallels.com>
> 
> Skype: aleksandr.kartashov
> Email: alekskartashov at parallels.com <mailto:alekskartashov at parallels.com>
>