[CRIU] [PATCH 01/20] x86: moved x86-specific files into the directory arch/x86.

[Cyrill Gorcunov]

On Wed, Dec 19, 2012 at 07:01:56PM +0400, Alexander Kartashov wrote:
> On 12/19/2012 06:56 PM, Cyrill Gorcunov wrote:
> >On Wed, Dec 19, 2012 at 06:45:18PM +0400, Alexander Kartashov wrote:
> >>Мне кажется, types.h --- плохой пример, поскольку если его
> >>положить в arch/$(ARCH)/include/asm, то он будет пересекатсья
> >>с системным заголовком. Кроме того, types.h только частично
> >>зависит от архитектуры.
> >>
> >>В целом, я с Вашим предложением согласен и хочу уточнить
> >>его следующим образом:
> >Lets stick with Pavel's proposal (ie
> >
> >  | Just keep arch-specific headers in arch/<arch>/include/asm/
> >
> >)
> 
> OK. Nevertheless, what should be done with include/types.h?
> Renaming it to prevent collision with the system asm/types.h
> seems to be unreasonable.

Wait, which collision you mean here?
In our header we define preproc guard as

#ifndef CR_TYPES_H_
#define CR_TYPES_H_

the system headers do have own guards which are not intersected
with ours. For asm-related stuff we could simply add CR_ASM_ prefix.

And it should be included in source code as "types.h" or "asm/types.h".

	Cyrill