[CRIU] [PATCH 01/20] x86: moved x86-specific files into the directory arch/x86.

[Stanislav Kinsbursky]

13.12.2012 16:46, Alexander Kartashov пишет:
> On 12/13/2012 04:32 PM, Stanislav Kinsbursky wrote:
>>>
>>> diff --git a/arch/x86/Makefile.inc b/arch/x86/Makefile.inc
>>> new file mode 100644
>>> index 0000000..b63bd25
>>> --- /dev/null
>>> +++ b/arch/x86/Makefile.inc
>>> @@ -0,0 +1,7 @@
>>> +DEFINES   += -DCONFIG_X86_64
>>> +ARCH_BITS := 64
>>> +
>>> +CC      := gcc
>>> +LD      := ld
>>> +OBJCOPY     := objcopy
>>> +LDARCH     := i386:x86-64
>>
>> Why do you need this file?
>> All these defines should be exported from global Makefile.
>
> Initially the ARM branch was cross-compiled so I had to have different values of these variables
> for ARM and x86. I think we shall leave this file in order to be able to cross-compile.
>

Maybe, we should discuss makefiles in person. But it will be probably after new year.
With this patch set they become extremely ugly and obscure.
Have a look at global Makefile like "DEFINES"  depend on arch type.
Maybe it can be done that way?


-- 
Best regards,
Stanislav Kinsbursky