[CRIU] [PATCH 08/20] restorer: introduced the multiarch support into the restorer.

Cyrill Gorcunov gorcunov at openvz.org
Wed Dec 12 11:02:05 EST 2012


On Wed, Dec 12, 2012 at 05:34:18PM +0400, alekskartashov at parallels.com wrote:
>  
>  		ret = sys_flock(fd, LOCK_UN);
> @@ -766,28 +709,26 @@ long __export_restore_task(struct task_restore_core_args *args)
>  
>  	ret = sys_munmap(args->task_entries, TASK_ENTRIES_SIZE);
>  	if (ret < 0) {
> -		ret = ((long)__LINE__ << 32) | -ret;
> +		ret = ((long)__LINE__ << 16) | ((-ret) & 0xffff);
>  		goto core_restore_failed;
>  	}

Hmm, why we've dropped sign propagation here? ((-ret) & 0xffff) eliminates
minus, mind to explain?

	Cyrill


More information about the CRIU mailing list