[CRIU] [PATCH 06/22] cpu: Prepare scaffold for obtaining cpu features

Pavel Emelyanov xemul at parallels.com
Wed Dec 12 09:14:23 EST 2012


On 12/12/2012 06:04 PM, Cyrill Gorcunov wrote:
> On Wed, Dec 12, 2012 at 05:47:29PM +0400, Pavel Emelyanov wrote:
>>> +#define X86_FEATURE_MTRR		(0*32+12) /* Memory Type Range Registers */
>>> +#define X86_FEATURE_PGE			(0*32+13) /* Page Global Enable */
>>> +#define X86_FEATURE_MCA			(0*32+14) /* Machine Check Architecture */
>>> +#define X86_FEATURE_CMOV		(0*32+15) /* CMOV instructions */
>>> +						  /* (plus FCMOVcc, FCOMI with FPU) */
>>
>> Why do we need all this crap, while we use only 3 of them?
> 
> These are common bits and I don't know which else we might need in near
> future. Keeping the whole cpuid infrastructure close to one implemented
> in kernel is certainly a win.

I believe it's not, at least now. Plz, trim this stuff, OK?


More information about the CRIU mailing list