[CRIU] [PATCH 05/22] protobuf: Update core.proto for new features

Cyrill Gorcunov gorcunov at openvz.org
Wed Dec 12 08:50:40 EST 2012


On Wed, Dec 12, 2012 at 05:40:53PM +0400, Pavel Emelyanov wrote:
> On 11/22/2012 01:05 AM, Cyrill Gorcunov wrote:
> > 
> > To restore FPU we will need
> > 
> >  - the xsave data
> >  - cpu parameters (features) data
> > 
> > Note the user_x86_fpregs_entry::padding left for backward
> > compatibility purpose since there might be images which
> > were checkpointed where we had no FPU support.
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  protobuf/core.proto |   15 +++++++++++++++
> >  1 files changed, 15 insertions(+), 0 deletions(-)
> > 
> 
> 
> > @@ -87,4 +101,5 @@ message core_entry {
> >  	optional task_core_entry	tc		= 3;
> >  	optional task_kobj_ids_entry	ids		= 4;
> >  	optional thread_core_entry	thread_core	= 5;
> > +	optional cpu_params		cpu		= 6;
> >  }
> 
> All tasks will have the same "cpu" value. Why not carrying
> the cpu_params stuff in separate image file?

It was _your_ (!) decision. I've been proposing to save it
cpu.img, but you said to keep it inside core params.

	Cyrill


More information about the CRIU mailing list