[CRIU] [PATCH] zdtm: mountpoints -- Explicitly remove old /dev/null

Cyrill Gorcunov gorcunov at openvz.org
Mon Dec 10 11:41:25 EST 2012


We should explicitly unlink old /dev/null instance, otherwise
if such device already exist we might hit a problem as

 | (00.002984) 7412 fdinfo 0: pos: 0x               0 flags:           100002/0
 | (00.003015) Dumping path for 0 fd via self 42 [/dev/null]
 | (00.003025) Error (files-reg.c:422): Unaccessible path opened 2049:109720, need 5:10
 | (00.003033) Error (cr-dump.c:1565): Dump files (pid: 7412) failed with -1

Reported-by: Alexander Kartashov <alekskartashov at parallels.com>
Tested-by: Alexander Kartashov <alekskartashov at parallels.com>
Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
---
 test/zdtm/live/static/mountpoints.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/zdtm/live/static/mountpoints.c b/test/zdtm/live/static/mountpoints.c
index 7de2ab1..afe0479 100644
--- a/test/zdtm/live/static/mountpoints.c
+++ b/test/zdtm/live/static/mountpoints.c
@@ -92,6 +92,7 @@ done:
 		return 1;
 	}
 
+	unlink("/dev/null");
 	mknod("/dev/null", 0777 | S_IFCHR, makedev(1, 3));
 
 	setup_outfile();
-- 
1.8.0.1



More information about the CRIU mailing list