[CRIU] [PATCH 6/7] inotify: Use ghost files if the watchee is a deleted file

Cyrill Gorcunov gorcunov at openvz.org
Wed Dec 5 08:46:49 EST 2012


On Wed, Dec 05, 2012 at 05:33:59PM +0400, Cyrill Gorcunov wrote:
> On Wed, Dec 05, 2012 at 05:30:20PM +0400, Pavel Emelyanov wrote:
> ...
> > >>> @@ -43,6 +44,7 @@
> > >>>  struct inotify_wd_info {
> > >>>  	struct list_head		list;
> > >>>  	InotifyWdEntry			*iwe;
> > >>> +	struct ghost_file		*gf;
> > >>
> > >> You don't want the whole gf here, you just need the remap.
> > > 
> > > I believe this will be ugly. Ghost file concept does operate with
> > > struct ghost_file so I don't see a reason to grind it down. And
> > > after all it's a _pointer_ not the structure which we carry here.
> > 
> > Please, use the file_remap in inotifies.
> 
> As you wish. I'll update.

Here are two patches which need to be updated - 4 and 7.

P.S.: Look, if the series on its own become messy (ie unclear which patches
are to be applied and in which order) I've pushed the updates to repo.
Consider simply pulling them in.

The following changes since commit 9bc0f5c67e6cbefd8856002c21c489c5b7f2c671:

  zdtm: Extend inotify00 test to have ghost file used (2012-12-05 17:42:36 +0400)

are available in the git repository at:

  git://github.com/cyrillos/crtools.git notify-3

for you to fetch changes up to 9bc0f5c67e6cbefd8856002c21c489c5b7f2c671:

	Cyrill


More information about the CRIU mailing list