[CRIU] Re: [PATCH cr 1/2] restore: use a currect stack for new processes (v3)

Cyrill Gorcunov gorcunov at openvz.org
Tue Aug 28 10:35:21 EDT 2012


On Tue, Aug 28, 2012 at 06:32:47PM +0400, Pavel Emelyanov wrote:
> On 08/28/2012 04:52 PM, Cyrill Gorcunov wrote:
> > On Tue, Aug 28, 2012 at 04:36:04PM +0400, Pavel Emelyanov wrote:
> >> On 08/28/2012 01:39 AM, Andrey Wagin wrote:
> >>> 2012/8/27 Pavel Emelyanov <xemul at parallels.com>:
> >>>> On 08/26/2012 12:47 AM, Andrey Vagin wrote:
> >>>>>
> >>>>> Why do we need a new stack? We already have one and it can be used.
> >>>>
> >>>> Shared stack?
> >>>
> >>> O_o We don't use CLONE_VM here, so it will not share.
> >>
> >> ok. why do we need char stack[] mem for it, why not give it the existing stack?
> >>
> >>> This code works like fork().
> > 
> > Because if we near the stack bottom in main crtools process we better
> > to fail early than later ;) This is not-likely situation but still possible.
> 
> Why fail? Won't it grow on demand?

It can't grow endlessly. As I said it's not-likely situation, but possible ;)

	Cyrill


More information about the CRIU mailing list