[CRIU] Re: [PATCH 6/6] tty: Add checkpoint/restore for unix terminals

[Cyrill Gorcunov]

On Tue, Aug 28, 2012 at 04:39:21PM +0400, Pavel Emelyanov wrote:
> On 08/27/2012 11:57 PM, Cyrill Gorcunov wrote:
> > On Mon, Aug 27, 2012 at 11:35:30PM +0400, Pavel Emelyanov wrote:
> >>
> >> After 5 minutes of looking through the patch I see that it _SHOULD_ be splitted in parts.
> > 
> > Well, it's not that easy because everything is bound ;)
> > I mean we could split it to dump and restore parts but
> > I don't see how else to split it _and_ make crtools still
> > workable after every commit. But I'll think about it.
> 
> Do your best, think hard and split. I will list parts when I'm back
> from vacation.

Yeah, I'm splitting it now with small snippets.

> >> Plus one comment about the code:
> >>
> >>> +       ... TTY_FILE_ENTRY__TTY_TYPE__PTY;
> >>
> >> O_O Great Scott!
> > 
> > Huh? What's problem?
> 
> The name itself.

I see. OK, will rename it to something more sensible.

	Cyrill