[CRIU] Re: [PATCH cr 1/2] restore: use a currect stack for new processes (v3)

Pavel Emelyanov xemul at parallels.com
Tue Aug 28 08:36:04 EDT 2012


On 08/28/2012 01:39 AM, Andrey Wagin wrote:
> 2012/8/27 Pavel Emelyanov <xemul at parallels.com>:
>> On 08/26/2012 12:47 AM, Andrey Vagin wrote:
>>>
>>> Why do we need a new stack? We already have one and it can be used.
>>
>> Shared stack?
> 
> O_o We don't use CLONE_VM here, so it will not share.

ok. why do we need char stack[] mem for it, why not give it the existing stack?

> This code works like fork().
> 
>>
>>> We need to step a bit for executing a glibc clone()
>>>
>>> v2: Don't lose a page from a child's stack
>>> v3: Remove the defined constant STACK_SIZE
>>>
>>> Signed-off-by: Andrey Vagin <avagin at openvz.org>
>>> ---
>>>  cr-restore.c |   22 ++++------------------
>>>  1 files changed, 4 insertions(+), 18 deletions(-)
>>>
>>
> .
> 



More information about the CRIU mailing list