[CRIU] Re: [PATCH cr] restore: connection should be unlocked bedore restoring

[Andrey Wagin]

2012/8/27 Pavel Emelyanov <xemul at parallels.com>:
> On 08/27/2012 04:55 PM, Andrey Vagin wrote:
>>
>> Otherwise it doesn't work...
>>
>> Actually we need to rework this part at all.
>>
>> Signed-off-by: Andrey Vagin <avagin at openvz.org>
>> ---
>>  cr-restore.c |    2 --
>>  sk-tcp.c     |    3 +++
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>
> I don't understand this change. Write better comment.

I wrote a test and found that a current code doesn't unlock tcp
connections, because crtools calls tcp_unlock_connections(), which
enumerates a list tcp_repair_sockets, but this list is not shared
between processes.

Then I found that it works fine if a connection unlocked before
restoring. Actually I don't understand a restoring tcp connections.
I'm going to understand this process at Wensday.