[CRIU] Re: [PATCH 6/6] tty: Add checkpoint/restore for unix terminals

[Cyrill Gorcunov]

On Mon, Aug 27, 2012 at 11:35:30PM +0400, Pavel Emelyanov wrote:
> 
> After 5 minutes of looking through the patch I see that it _SHOULD_ be splitted in parts.

Well, it's not that easy because everything is bound ;)
I mean we could split it to dump and restore parts but
I don't see how else to split it _and_ make crtools still
workable after every commit. But I'll think about it.

> 
> Plus one comment about the code:
> 
> > +       ... TTY_FILE_ENTRY__TTY_TYPE__PTY;
> 
> O_O Great Scott!

Huh? What's problem? PTY is a special type of tty, I'm not
sure which else tty types we will need in future thus I've
splitted pty type to be a separate one.

	Cyrill