[CRIU] Re: [PATCH] protobuf: use pretty output for unix sockets

Pavel Emelyanov xemul at parallels.com
Tue Aug 21 08:08:31 EDT 2012


On 08/21/2012 03:52 PM, Cyrill Gorcunov wrote:
> On Tue, Aug 21, 2012 at 03:46:11PM +0400, Pavel Emelyanov wrote:
>> On 08/21/2012 03:42 PM, Kinsbursky Stanislav wrote:
>>> 21.08.2012 15:22, Pavel Emelyanov пишет:
>>>> On 08/20/2012 08:05 PM, Kinsbursky Stanislav wrote:
>>>>> From: Stanislav Kinsbursky <skinsbursky at openvz.org>
>>>>>
>>>>> New custom specificator:
>>>>>
>>>>> 'U': output as unix socket address
>>>> Better 'S' -- as string but carefully, replacing non printable chars with dots.
>>>
>>> What do you really want? Some generic output method for "bytes" field or only 
>>> unix socket name output?
>>
>> I want:
>>
>> 1. generic method for dumping repeated bytes field
>> 2. string-like method for dumping repeated bytes field
>>
>> these two are controversial. For unix socket names the 2nd one should be used
>> for others -- the 1st one (default)
> 
> Guys, we've had hexdump like code for printing out page contents (if my memory
> doesn't betray me) so maybe we can re-use it?

We can, but for unix paths it's not convenient. That's why I need modifier.

> 	Cyrill




More information about the CRIU mailing list