[CRIU] Re: [PATCH cr 1/4] zdtm: rework logging
Andrew Vagin
avagin at parallels.com
Mon Aug 20 09:30:18 EDT 2012
On Mon, Aug 20, 2012 at 05:14:15PM +0400, Pavel Emelyanov wrote:
> On 08/20/2012 04:56 PM, Andrey Vagin wrote:
> >
> > * Delete internal buffer, all data are written immediately in a log file
>
> It was done so not just for fun, wasn't it?
Yes, I don't know why we need previous tricky logic.
We lose all logs if a test process was killed (e.g.: by SEGV).
I had a discussion with the author and he doesn't mind such rework
>
> > * Add timestamp and pid in a message
> > * All processes write log messages in one file
> >
> > Signed-off-by: Andrey Vagin <avagin at openvz.org>
> > ---
> > test/zdtm/lib/msg.c | 85 +++++++++++++++++------------------
> > test/zdtm/lib/test.c | 26 +++++++----
> > test/zdtm/lib/zdtmtst.h | 3 +-
> > test/zdtm/live/static/mountpoints.c | 7 ++-
> > 4 files changed, 65 insertions(+), 56 deletions(-)
> >
>
More information about the CRIU
mailing list