[CRIU] Re: [PATCH cr] dump: save all vdso pages

[Pavel Emelyanov]

On 08/20/2012 01:56 PM, Andrey Vagin wrote:
> 
> If a vdso page was not accessed before dump, it's not present
> and now it doesn't save in a dump image.
> The vdso area is restored as VMA_ANON, it isn't an actual vdso more,
> so when a not-present vdso page is accessed, a zero page would be mapped.
> 
> For this reason we should save all vdso pages in a image.
> 
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  parasite.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 

OK, but plz, split this function from

return A || B && !C

view into

if (A)
	return 1;
if (C)
	return 0;
if (B)
	return 1;

return 0;

form. It's too hard to parse the former version.