[CRIU] Re: [PATCH 4/4] cr-restore: read pages to temporary file if migrating

[Pavel Emelyanov]

On 08/16/2012 10:50 PM, Adrian Reber wrote:
> On Thu, Aug 16, 2012 at 08:11:23PM +0400, Pavel Emelyanov wrote:
>> On 08/16/2012 08:02 PM, Adrian Reber wrote:
>>> On Wed, Aug 15, 2012 at 02:54:12PM +0400, Pavel Emelyanov wrote:
>>>> On 08/15/2012 01:54 PM, Adrian Reber wrote:
>>>>> This is a hack until it is possible to read the pages-*.img directly
>>>>> from restorer.c over a network socket. This workaround opens
>>>>> a temporary file on /dev/shm which is then used by restorer.c to
>>>>> read pages-*.img.
>>>>
>>>> I don't see any code, that closes one and then removes. 
>>>
>>> Yes that is missing. I will fix that.
>>
>> What prevents you from reading pages with data right from the socket?
> 
> I tried passing my socket as a FD into the restorer but for some reason
> it was not working. I will try it once more to not write to a temporary
> file but reading directly from the network socket. My goal was to get it
> work and therefore I choose the ugly hack with the temporary file.
> 
> I will repost the patchset with move_img_fd() and without the hack with
> the temporary file in /dev/shm.

OK. Thank you for your work, we really appreciate that!

> 		Adrian
> .
>