[CRIU] Re: [PATCH 2/4] dump: Add futex robust list dumping

Pavel Emelyanov xemul at parallels.com
Fri Aug 10 04:26:05 EDT 2012


On 08/09/2012 09:36 PM, Cyrill Gorcunov wrote:
> On Thu, Aug 09, 2012 at 08:29:38PM +0400, Cyrill Gorcunov wrote:
>> Note the proto file has been extended.
>>
>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>> ---
> 
> Updated version attached

> diff --git a/protobuf/core.proto b/protobuf/core.proto
> index 4fd5753..c44419a 100644
> --- a/protobuf/core.proto
> +++ b/protobuf/core.proto
> @@ -64,6 +64,9 @@ message thread_info_x86 {
>  	required uint64			clear_tid_addr	= 1;
>  	required user_x86_regs_entry	gpregs		= 2;
>  	required user_x86_fpregs_entry	fpregs		= 3;
> +
> +	optional uint64			futex_rla	= 4;
> +	optional uint32			futex_rla_len	= 5;
>  }
>  
>  message core_entry {

Robust list is not x86 arch specific and thus shouldn't be on thread_info_x86.
Neither it can be on task_core_entry as it's per-thread thing.

Let's introduce an optional thread_core_entry entry on core_entry and put these
two in there.

Thanks,
Pavel


More information about the CRIU mailing list