[CRIU] Re: [PATCH cr 3/3] mount: add support of tmpfs

Pavel Emelyanov xemul at parallels.com
Thu Aug 9 08:14:41 EDT 2012


On 08/09/2012 02:15 PM, Andrey Vagin wrote:
> 
> tar is used for dumping content of tmpfs
> 
> v2: Fail if if something is mounted on top of tmpfs
> 
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  image.c                             |    1 +
>  include/crtools.h                   |    2 +
>  include/image.h                     |    1 +
>  mount.c                             |  127 +++++++++++++++++++++++++++++++++++
>  test/zdtm/live/static/mountpoints.c |   12 +++-
>  5 files changed, 142 insertions(+), 1 deletions(-)
> 

> +	if (!list_empty(&pm->children)) {
> +		pr_err("Something is mounted on top of tmpfs\n");
> +		return -1;
> +	}
> +

I believe this should be in open_mountpoint. Later, we will teach it
how to open an overmounted mountpoint.

Plus, introduce the close_mountpoint() fn which will now only close an
fd, but later will do more.

Thanks,
Pavel


More information about the CRIU mailing list