[CRIU] Re: [PATCH] protobuf: use pretty output for inet sockets

Pavel Emelyanov xemul at parallels.com
Mon Aug 6 10:46:02 EDT 2012


On 08/02/2012 02:54 PM, Kinsbursky Stanislav wrote:
> From: Stanislav Kinsbursky <skinsbursky at openvz.org>
> 
> New custom specificators:
> 
> 'F': output as socket address family
> 'T': output as socket address type
> 'P': output as socket address protocol
> 'S': output as socket address state
> 'A': output as socket address

No, the format should always be %<something>. And we need to
extend the %p formatter in a way printk is done in the kernel,
i.e. %pI for inet address.

Special formats for address family, type, protocol and state are
excessive :\

> Note: added cookie to field descriptor. For sockets it's used to store family
> type. BTW, for each message in will be initially set to zero. Hope, we won't
> have a message with two sockets with different family in future.
> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky at openvz.org>
> ---
>  protobuf.c |   34 +++++++++++++++++++++++++++++++++-
>  sk-inet.c  |   40 +---------------------------------------
>  2 files changed, 34 insertions(+), 40 deletions(-)



More information about the CRIU mailing list