[CRIU] Re: [PATCH] restore: Order file restoring by their type

Cyrill Gorcunov gorcunov at openvz.org
Sat Apr 28 09:59:29 EDT 2012


On Sat, Apr 28, 2012 at 05:52:35PM +0400, Pavel Emelyanov wrote:
> On 04/28/2012 05:36 PM, Cyrill Gorcunov wrote:
> > We need the files being restored in order of their
> > type. In particular when we restore eventpoll file
> > we expect every file descriptor the epoll watches on
> > is already created and opened.
> 
> I'd explicitly restore only eventpoll files at the very
> end instead.

Why? I think restoration driven by enum order is better.
If I do what you propose -- I'll have to add tests for
file not being eventpoll to restore them afetr all other
files. Moreover I need the same for inotify. Which will
make code uglier.

	Cyrill


More information about the CRIU mailing list