[CRIU] Re: [PATCH 3/4] eventfd: Add checkpoint/restore support

[Cyrill Gorcunov]

On Tue, Apr 24, 2012 at 05:58:18PM +0400, Pavel Emelyanov wrote:
> > +int dump_one_eventfd(int lfd, u32 id, const struct fd_parms *p)
> > +{
> > +	int image_fd = fdset_fd(glob_fdset, CR_FD_EVENTFD);
> > +	struct eventfd_file_entry efe;
> > +
> > +	efe.id		= id;
> > +	efe.flags	= p->flags;
> > +	efe.fown	= p->fown;
> > +
> > +	if (ioctl(lfd, EFD_RAW_COUNTER, &efe.counter)) {
> > +		pr_perror("Failed to retrieve eventfd counter on %d", lfd);
> > +		return -1;
> > +	}
> 
> Flags are missing. I mean the kernel's eventfd_ctx->flags bits.

Yeah, this blocks usage of eventfd as semaphore. Thanks for spotting!

	Cyrill