[CRIU] Re: [PATCH 06/13] make: Add own Makefile.pie for binary blobs we generate

Cyrill Gorcunov gorcunov at openvz.org
Wed Apr 18 06:46:33 EDT 2012


On Wed, Apr 18, 2012 at 02:42:57PM +0400, Pavel Emelyanov wrote:
> On 04/18/2012 01:35 PM, Cyrill Gorcunov wrote:
> > On Wed, Apr 18, 2012 at 12:22:04PM +0400, Pavel Emelyanov wrote:
> >>> -RSRCS-BLOB	+= $(patsubst %.o,%.c,$(ROBJS))
> >>> +DEPS		:= $(patsubst %.o,%.d,$(OBJS))
> >>>  
> >>> -RSRCS-BLOB	+= $(patsubst %.o,%.c,$(ROBJS-BLOB))
> >>> -
> >>> -RHEAD-BLOB-GEN	:= $(patsubst %.o,%-blob.h,$(ROBJS-BLOB))
> >>> -RHEAD-BIN	:= $(patsubst %.o,%.bin,$(ROBJS-BLOB))
> >>> -
> >>> -DEPS		:= $(patsubst %.o,%.d,$(OBJS))		\
> >>> -       		   $(patsubst %.o,%.d,$(OBJS-BLOB))	\
> >>> -		   $(patsubst %.o,%.d,$(ROBJS-BLOB))
> >>> -
> >>> -GEN-OFFSETS	:= gen-offsets.sh
> >>> +-include Makefile.pie
> >>
> >> Why -include? Makefile.pie always exists.
> > 
> > It will issue error if someone occasionally delete this
> > file from source code, in turn plain "include" simply
> > ignores such case.
> 
> So, why do we want to ignore this error?

Crap, I wanted the reverse :) To _not_ ignore errors.
So it should be "include" instead. Sorry.

	Cyrill


More information about the CRIU mailing list