[CRIU] Re: [PATCH 4/4] sockets: Restore unconnected dgram sockets v4

Cyrill Gorcunov gorcunov at openvz.org
Tue Apr 17 10:35:27 EDT 2012


> > > @@ -1483,6 +1558,9 @@ int resolve_unix_peers(void)
> > >  		if (!ui->ue.peer)
> > >  			continue;
> > >  
> > > +		if ((ui->ue.uflags & USK_EXTERN) && opts.ext_unix_sk)
> > > +			continue;
> > > +
> > >  		peer = find_unix_sk(ui->ue.peer);
> > >  		if (!peer) {
> > >  			pr_err("FATAL: Peer 0x%x unresolved for 0x%x\n",
> > 
> > External socket cannot have a peer on it. Otherwise it's not "external" but "lost internal".
> > 
> 
> yes, this snippet is redundant.

If the explanation is fine for you, could you please drop this sinpet with some
simple cleanup commit on top?

	Cyrill


More information about the CRIU mailing list