[CRIU] on 0x prefix in messages

Cyrill Gorcunov gorcunov at openvz.org
Tue Apr 17 05:28:07 EDT 2012


Hi Stas,

the commit 35eedb5f1ffc260a5d2b6782a9b2b0fbfd7e3857
brought in 0x prefix for hex numbers but unfort. you've
added some prefixes without leading 0 pad. In particular
sockets.c

@@ -1131,7 +1131,7 @@ void show_unixsk(int fd, struct cr_options *o)
 		if (ret <= 0)
 			goto out;
 
-		pr_msg("id %8x type %s state %s namelen %4d backlog %4d peer %8x flags %2x",
+		pr_msg("id 0x%8x type %s state %s namelen %4d backlog %4d peer 0x%8x flags 0x%2x",

without "0" filler I see output

CR_FD_UNIXSK
----------------
id 0x    f7c6 type  dgram state closed namelen    0 backlog    0 peer 0x    f7bd flags 0x 2 uflags 0x 0
	fown: uid: 0x0 euid: 0x0 signum: 0x0 pid_type: 0x0 pid: 0
id 0x    f7bd type  dgram state listen namelen    9 backlog    0 peer 0xffffffff flags 0x 0 uflags 0x 1 --> /dev/log
	fown: uid: 0x0 euid: 0x0 signum: 0x0 pid_type: 0x0 pid: 0
----------------

while it should be "id 0x0000f7c6". Please fix it when you get a chance.

	Cyrill


More information about the CRIU mailing list