[CRIU] Re: [PATCH 2/4] sockets: Restore unconnected dgram sockets

Pavel Emelyanov xemul at parallels.com
Mon Apr 16 06:43:19 EDT 2012


> Like this one (still not for merging)

> -	static const char short_opts[] = "dsf:p:t:hcD:o:n:v";
> +	static const char short_opts[] = "dsf:p:t:hcD:o:n:vx";

I've added support for long options. This one is VERY specific and should be
long-option only.

> +			pt.id		= peer->sd.ino;
> +			pt.type		= SOCK_DGRAM;
> +			pt.state	= TCP_LISTEN;
> +			pt.namelen	= peer->namelen;
> +			pt.flags	= O_EXTERN;
> +			pt.peer		= -1u;

I meant not the file flags, but yet another flags field. I.e., where you stored
the INFLIGHT bit. We'll have yet another flag on it (unlinked name), so worth adding such.

> @@ -1239,6 +1268,7 @@ try_again:
>  		if (set_fd_flags(fle->fd, ui->ue.flags))
>  			return -1;
>  
> +next:

O_o

>  		cj = cj->next;
>  	}
>  

Otherwise looks great. Plz, fix the above minors and I'll apply.


More information about the CRIU mailing list