[CRIU] Re: [PATCH 2/4] sockets: Restore unconnected dgram sockets

[Cyrill Gorcunov]

On Mon, Apr 16, 2012 at 10:07:41AM +0400, Pavel Emelyanov wrote:
> > @@ -478,6 +481,7 @@ usage:
> >  	pr_msg("  -s             leave tasks in stopped state after checkpoint instead of killing them\n");
> >  	pr_msg("  -n             checkpoint/restore namespaces - values must be separated by comma\n");
> >  	pr_msg("                 supported: uts, ipc\n");
> > +	pr_msg("  -r             resolve unconnected socket peer connection by name\n");
> 
> I'd make the option meaning "allow external unix connections".
> 

OK. Maybe some another letter here, not 'r' but say 'x'?

> > +
> > +			/*
> > +			 * Socket is not connected back but have a name,
> > +			 * so at restore time we will find it here. Note
> > +			 * the id is set to impossible value by purpose.
> > +			 */
> > +
> > +			pt.id		= -1u;
> 
> This is wrong. You can have two or more sockets in the "image" to be connected
> to this "external" one. E.g. two daemons connected to /dev/log

Ie you mean, this peer should be written into image only once, right?

> > +static LIST_HEAD(unix_sockets_peer_names);
> 
> I don't see much profit in having separate list for external sockets.
> The existing infrastructure just allows for adding them in the common
> trunk.

OK

	Cyrill