[CRIU] [PATCH] sockets: Print sockets ino and peer with %x format

Stanislav Kinsbursky skinsbursky at parallels.com
Fri Apr 13 09:35:06 EDT 2012


13.04.2012 17:11, Cyrill Gorcunov пишет:
> On Fri, Apr 13, 2012 at 05:01:47PM +0400, Stanislav Kinsbursky wrote:
>> 13.04.2012 16:53, Cyrill Gorcunov пишет:
>>> Some ino/peers are printed with %d, some with %x,
>>> get rid of it and print all in %x.
>>>
>>
>>
>> 1) Why?
>
> Because I'm debuggin a problem and found that when we print
> image we use hex numbers, while when we print "Collected"
> we print ino in decimal format and I must admit I don't have
> skills to easily convert random numbers from dec to hex and
> back in head, espec if they are more than byte long.
>

I was questioning, why not dec?

>> 2) Hex values without "0x" prefix are confusing.
>
> Not really, but then we shold make a flag day and convert
> all %[][]x format to 0x%[][]x since we already have a number
> of places with invisible 0x.
>

Agreed. This should be done.


-- 
Best regards,
Stanislav Kinsbursky



More information about the CRIU mailing list