[CRIU] Re: [PATCH 2/4] pipes: Cleanup pipe_should_open_transport

Cyrill Gorcunov gorcunov at openvz.org
Thu Apr 12 06:21:55 EDT 2012


On Thu, Apr 12, 2012 at 02:18:03PM +0400, Pavel Emelyanov wrote:
> >  static int pipe_should_open_transport(struct fdinfo_entry *fe,
> >  		struct file_desc *d)
> >  {
> > -	struct pipe_info *pi;
> > -	
> > -	pi = container_of(d, struct pipe_info, d);
> > +	struct pipe_info *pi = container_of(d, struct pipe_info, d);
> 
> I prefer assignments on declaration to be only with constants and variables,
> but not anything looking as a call (i.e. with braces).

OK, as you wish.

	Cyrill


More information about the CRIU mailing list